From: Peter C. McCluskey (pcm@rahul.net)
Date: Mon May 12 2003 - 13:38:22 CDT
jose.kahan@w3.org (Jose Kahan) writes:
>> There's no default that does any equivalent of
>> "body {color: black; background: #ffffff}". Something should be done about
>> that.
>
>This can be solved through CSS, by adding a rule saying:
>
> body { color: black;
> background-color: #ffffff;
> }
>
>Should I add that default rule?
I think so.
If you do this and add the patch I'm appending, I think it will be ok
for you to commit your changes (although I hope others will test it and
provide feedback).
>Up to now, if the user doesn't specify a default CSS, we're embedding
>CSS rules at the top of each file produced by hypermail. After thinking
>about this, I guess this was the wrong approach (I'm the one who had
>proposed it, so blame me!). I think that it would be good to change
>this so that hypermail points to a default CSS location, e.g.,
>the directory where the archive is being produced, and have hypermail
>copy or generate a default CSS file there. Then have all the messages
>point there. This way, you can change all your style without having
>to rebuild the archive.
>
>What do you think about this?
I have no opinion on this.
jose.kahan@w3.org (Jose Kahan) writes:
>Peter,
>
>I think I've added the backwards compatibility and while doing so,
>understood and fixed the finelink.c:replace_maybe_replies() crash
>you reported. It was related.
The crash was not fixed in the tarball I just downloaded. Here is a patch
which I think fixes it:
--- finelink.c Mon May 12 09:03:27 2003
+++ finelink.c.new Mon May 12 11:16:11 2003
@@ -578,9 +578,17 @@
"<li> <b>Previous message:</b> <a href=\"",
"<li> <strong>%s:</strong> <a href=\"",
"<li><dfn>%s:</dfn> <a href=\"",
+ "<li><dfn>%s:</dfn> <a href=\"",
+ "<li><dfn>%s:</dfn> <a href=\"",
NULL
};
static const int indices[] = { MSG_MAYBE_IN_REPLY_TO,
+ MSG_MAYBE_IN_REPLY_TO,
+ MSG_IN_REPLY_TO,
+ MSG_IN_REPLY_TO,
+ MSG_PREVIOUS_MESSAGE,
+ MSG_PREVIOUS_MESSAGE,
+ MSG_MAYBE_IN_REPLY_TO,
MSG_IN_REPLY_TO,
MSG_PREVIOUS_MESSAGE
};
@@ -588,7 +596,7 @@
int surpress = 0;
for (i = 0; patts[i]; ++i) {
char temp[256];
- snprintf(temp,sizeof(temp), patts[i], lang[indices[i / 2]]);
+ snprintf(temp,sizeof(temp), patts[i], lang[indices[i]]);
if ((ptr = strcasestr(buffer, temp))
&& (i < 4 || new_reply_to == atoi(ptr + strlen(temp)))) {
surpress = 1;
--
------------------------------------------------------------------------------
Peter McCluskey | "To announce that there must be no criticism of
http://www.rahul.net/pcm | the President, or that we are to stand by the
| President right or wrong, is not only unpatriotic
| and servile, but morally treasonable to the
| American public." - Theodore Roosevelt