From: Peter C. McCluskey (pcm@rahul.net)
Date: Tue Dec 07 1999 - 20:17:23 CST
bre@netverjar.is ("Bjarni R. Einarsson") writes (about a month ago):
>One quick unrelated thing - are the "Reply:" and "Maybe Reply:" lines in
>hypermail 2b25's output working as expected?
No. I've appended a patch to 2b28 which fixes them to probably work as well
as the current threading allows. It does tend to make the limitations of
the current threading more obvious. The set_linkquotes option that I plan
to introduce when the code freeze ends will fix many of those threading
problems.
>What is the Reply line for, anyway? It's totally unclear to me.
When working, it helps you find the replies to the message you're reading.
--- print.c.old Sun Nov 28 18:33:38 1999
+++ print.c Tue Dec 7 17:57:23 1999
@@ -864,7 +864,8 @@
if (set_showreplies) {
for (rp = replylist; rp != NULL; rp = rp->next) {
- if (rp->msgnum == num) {
+ if (rp->frommsgnum == num
+ && hashnumlookup(rp->msgnum, &email2)) {
if (rp->maybereply)
fprintf(fp, "<LI><STRONG>%s:</STRONG>",
lang[MSG_MAYBE_REPLY]);
@@ -872,10 +873,9 @@
fprintf(fp, "<LI><STRONG>%s:</STRONG>",
lang[MSG_REPLY]);
fprintf(fp, " <A HREF=\"%.4d.%s\">",
- rp->frommsgnum, set_htmlsuffix);
- fprintf(fp, "%s: \"%s\"</A>\n",
- rp->data->name,
- ptr = convchars(rp->data->subject));
+ rp->msgnum, set_htmlsuffix);
+ fprintf(fp, "%s: \"%s\"</A>\n", email2->name,
+ ptr = convchars(email2->subject));
free(ptr);
}
}
@@ -977,7 +977,8 @@
This should be cleaned up to use threadprint.c functions */
for (rp = replylist; rp != NULL; rp = rp->next) {
- if (rp->msgnum == num) {
+ if (rp->frommsgnum == num
+ && hashnumlookup(rp->msgnum, &email2)) {
if (rp->maybereply)
fprintf(fp, "<LI><STRONG>%s:</STRONG>",
lang[MSG_MAYBE_REPLY]);
@@ -985,10 +986,9 @@
fprintf(fp, "<LI><STRONG>%s:</STRONG>",
lang[MSG_REPLY]);
fprintf(fp, " <A HREF=\"%.4d.%s\">",
- rp->frommsgnum, set_htmlsuffix);
- fprintf(fp, "%s: \"%s\"</A>\n",
- rp->data->name,
- ptr = convchars(rp->data->subject));
+ rp->msgnum, set_htmlsuffix);
+ fprintf(fp, "%s: \"%s\"</A>\n", email2->name,
+ ptr = convchars(email2->subject));
free(ptr);
}
}
-- ------------------------------------------------------------------------ Peter McCluskey | Boycott Amazon.com until they stop suing http://www.rahul.net/pcm | companies that support 1-click shopping.